[Rpm-maint] [rpm-software-management/rpm] rpmsign --delsign leaves behind 0 padding (Issue #2965)

[Panu Matilainen]

I seem to have missed the last update here:

> The obs-sign we use in OBS has its own signing code and adds bytes to the header instead of using the reserved space.

This is where things go into the weeds. Like I said in an earlier comment, rpm *cannot guarantee* going back to the original state of the package because it has no idea what the reservation size was. It operates by the assumption that the reserved space is used.

>  The rpm --delsign leaves the (increased) size as is, only zeroes it out.

This is by design. Resizing is expensive, so it doesn't make sense to shrink the file on --delsign because we might get signed again and then we might need to an expensive grow, again. And, since we don't know what the original reservation was so we wouldn't know what to resize to even if we wanted to.

So this is not a regression, you should teach the obs-sign thing to take advantage of the reserved space when available, and then it'll play ball with rpmsign --delsign.

Very old rpm does not know about reserved space so it behaves differently. IIRC it was added in 4.13. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2965#issuecomment-2173394196
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/issues/2965/2173394196 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240617/6d89d67d/attachment.html>