[Rpm-maint] [rpm-software-management/rpm] Pass TZ=UTC to zip in rpmuncompress (PR #3170)

Panu Matilainen notifications at github.com
Tue Jun 18 11:32:57 UTC 2024


@pmatilai commented on this pull request.



> @@ -223,6 +223,7 @@ int main(int argc, char *argv[])
 
 	if (dryrun) {
 	    ec = EXIT_SUCCESS;
+	    free(cmd);

Just move the existing free below the exit label so it gets handled for all cases now and in the future, I don't know why I've put the free where it is now. It's a fine example of why the clean-centrally-at-exit is so important in C. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3170#pullrequestreview-2125252013
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3170/review/2125252013 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240618/1cc57e5e/attachment.html>


More information about the Rpm-maint mailing list