[Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)

Shreenidhi Shedi notifications at github.com
Thu May 2 17:19:18 UTC 2024


@nwalfield Thanks for reviewing.
> and some are weird, like having #define LEN 102400 // 100 * 1024

It would help me understand things better if you explain a bit on why it is weird.
My intent behind the change is, why calculate something on every run which can be used directly?

I'm completely okay if this doesn't get merged, people spent time to review my change and gave suggestions and I should respect that so I spent time on this and tried to do it right. It's upto the maintainers now, I have done my part.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-2091106326
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3072/c2091106326 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240502/17c26def/attachment-0001.html>


More information about the Rpm-maint mailing list