[Rpm-maint] [rpm-software-management/rpm] Convert major librpmbuild structs to native C++ allocation / initialization (PR #3099)

Daniel Alley notifications at github.com
Wed May 15 17:18:10 UTC 2024


@dralley commented on this pull request.



>  }
 
 StringBuf freeStringBuf(StringBuf sb)
 {
-    if (sb) {
-	sb->buf = _free(sb->buf);
-	sb = _free(sb);
-    }
-    return sb;
+    delete sb;

I assume / hope there's an intention to move away from `new` / `delete` at a later stage of refactoring?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3099#pullrequestreview-2058598175
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3099/review/2058598175 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240515/ac963f0e/attachment.html>


More information about the Rpm-maint mailing list