[Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

[Michael Schroeder]

@mlschroe commented on this pull request.



> @@ -14,6 +14,16 @@
 extern "C" {
 #endif
 
+/** \ingroup rpmkeyring
+  * Operation mode definitions for rpmKeyringModify
+  */
+typedef enum rpmKeyringModifyMode_e {
+    RPMKEYRING_ADD	= 1,
+    RPMKEYRING_REPLACE	= 2,
+    RPMKEYRING_DELETE	= 3

This is about if you do the merge in the keyring code or in the import code. I played with both options and then settled in doing the merge call in the import code and then replacing the old pubkey with the merged pubkey.

It's up to the merge code if it wants to keep all binding signatures. The rpmpgp_legacy merge code does not throw away any pgp package.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3083#discussion_r1609868304
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3083/review/2071057862 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240522/b9517118/attachment.html>