[Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -509,6 +509,19 @@ int pgpSignatureType(pgpDigParams sig);
  */
 char *pgpIdentItem(pgpDigParams digp);
 
+/** \ingroup rpmpgp
+ * Merge the PGP packets of two public keys
+ * @param pkts1		OpenPGP pointer to a buffer of first certificates
+ * @param pkts1len	length of the buffer with first certificates
+ * @param pkts2		OpenPGP pointer to a buffer of second certificates
+ * @param pkts2len	length of the buffer with second certificates
+ * @param pktsm[out]	merged certificates (malloced)
+ * @param pktsmlen[out]	length of merged certificates
+ * @param flags		merge flags (currently not implemented)

I'd rather have a flags arg we never end up using than not having it when we need it. Rpm is traditionally terribly sloppy with these, but indeed it'd be good to state the only legit value now is 0 so people don't end up passing random stuff that hurts us later (been there).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3083#discussion_r1611400268
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3083/review/2073498999 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240523/5c020316/attachment-0001.html>