[Rpm-maint] [rpm-software-management/rpm] Fix incomplete header on plain src.rpm build modes regression (PR #3127)

Panu Matilainen notifications at github.com
Mon May 27 10:58:51 UTC 2024


Since 9165963de8bb5d5ad0a24ea4656d6d04d733f6bc, the main header wasn't getting properly filled on plain src.rpm build modes like -bs. So a lot of things was missing, but spotted in particular because %packager wasn't getting set as per macros in Koji. Fix by letting rpm finalize the spec after parse when no dynamic spec parts are to be executed.

Add a bunch of tests around this - we can't possibly test every single build scenario but this should cover at least the most common ones pretty well.

Reported-by: Miro Hrončok <miro at hroncok.cz>
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3127

-- Commit Summary --

  * Fix incomplete header on plain src.rpm build modes regression

-- File Changes --

    M tests/rpmbuild.at (55)
    M tools/rpmbuild.c (14)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3127.patch
https://github.com/rpm-software-management/rpm/pull/3127.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3127
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3127 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240527/325b20cd/attachment.html>


More information about the Rpm-maint mailing list