[Rpm-maint] [rpm-software-management/rpm] --build-in-place multiple flaws (Issue #3131)

[Panu Matilainen]

This is all very valuable feedback, thanks! 

Yeah your systemd usage is a rather evolved case, with lots of external (from rpm POV) infra to support it that's not (at least currently) available to rpmbuild alone. Like the writable overlay which makes patching not an issue, but without such a thing its basically down to copy or disable (patches), because otherwise it doesn't work / is not sensible. 

This probably needs to be switchable somehow. Maybe there could be a macro/script hook you need to define to enable %prep processing with build-in-place, and the hook would be responsible for copying/mounting/whatever (or I guess in your case, just "nop" because its handled elsewhere) magic needed to make patching a meaningful operation. It *could* also be switching to a new temporary branch in git, where you can apply all the patches you want and then restore at end.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3131#issuecomment-2136817705
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/issues/3131/2136817705 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240529/107ad581/attachment.html>