[Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

Neal H. Walfield notifications at github.com
Thu Nov 7 12:08:16 UTC 2024


@nwalfield commented on this pull request.

Only a few small nits.  Feel free to ignore.

>  **rpmkeys** **\--list**
 
-More details about a specific public key, when imported, can be displayed by
-querying. Here\'s information about the Red Hat GPG/DSA key:
-
-**rpm -qi gpg-pubkey-db42a60e**
+This lists all currently imported public keys (aka certificates)

A small suggestion: I try to to not start paragraphs with a demonstrative pronoun (this or that) and instead name the thing that I'm talking about.  My experience is that this makes scanning easier as the reader doesn't have to decipher the referent.  So in this case, I would suggest "This command."

>  **rpmkeys** **\--list**
 
-More details about a specific public key, when imported, can be displayed by
-querying. Here\'s information about the Red Hat GPG/DSA key:
-
-**rpm -qi gpg-pubkey-db42a60e**
+This lists all currently imported public keys (aka certificates)
+by their fingerprint and User ID. The fingerprint is the handle

s/User ID/user ID/.  (In case you picked this up from our documentation, I'm sorry!  It's also not consistently correct there.)

>  
-**rpmkeys** **\--export**
+Write the key(s) in an armor wrapped text format to standard out.

Suggestion: s/armor wrapped text format/using an ASCII-armor encoding/

>  
-Or alternatively:
+Delete the keys in *FINGERPRINT*. For example:

Suggestion: s/in/designated by/

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3433#pullrequestreview-2420791650
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3433/review/2420791650 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241107/e12fecb3/attachment.html>


More information about the Rpm-maint mailing list