[Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)
Florian Festi
notifications at github.com
Mon Nov 11 17:25:09 UTC 2024
@ffesti commented on this pull request.
>
- if (replace) {
- rasprintf(&tmppath, "%s.new", path);
- unlink(tmppath);
+ rc = write_key_to_disk(key, dirstr, keyfmt, replace, flags);
+
+ if (!rc && replace) {
+ /* find and delete the old pubkey entry */
Yeah, I thought it wouldn't make a big difference having it in one patch as it just adds the new backend. I should have reconsidered when seeing the mess the diff made out of that.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3437#discussion_r1836993450
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3437/review/2427817721 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241111/2f0a5992/attachment.html>
More information about the Rpm-maint
mailing list