[Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)

[Michal Domonkos]

@dmnks commented on this pull request.



>  
-    if (!rc && replace) {
-	/* find and delete the old pubkey entry */
-	if (delete_key(txn, fp, keyfmt) == RPMRC_NOTFOUND) {
-	    /* make sure an old, short keyid version gets removed */
-	    delete_key(txn, fp+32, keyfmt);
-	}
-    }
+static void free_write_lock(int fd)
+{
+    flock(fd, LOCK_UN);

Hmm, perhaps not really. The spec only says the store should be assumed unlocked if the file doesn't exist, but its presence doesn't really matter (as long as we use `flock()` of course).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3437#discussion_r1837728117
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3437/review/2428965011 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241112/af8ea960/attachment.html>