[Rpm-maint] [rpm-software-management/rpm] Add internal C++ native path manipulation functions (PR #3442)

Panu Matilainen notifications at github.com
Tue Nov 12 11:38:09 UTC 2024


@pmatilai commented on this pull request.



> @@ -306,79 +307,34 @@ char *rpmCleanPath(char * path)
     return path;
 }
 
-/* Merge 3 args into path, any or all of which may be a url. */
+/* Merge 3 args into path */

Not really, the URL support never worked at all (as is explained in the commit message and the API docs update). Any URL's in there and the output is utterly useless garbage.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3442#discussion_r1837954418
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3442/review/2429355685 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241112/bfaa9bd0/attachment.html>


More information about the Rpm-maint mailing list