[Rpm-maint] [rpm-software-management/rpm] Enable hardening options in the build (PR #3445)
Panu Matilainen
notifications at github.com
Thu Nov 14 12:46:21 UTC 2024
@pmatilai commented on this pull request.
> @@ -82,8 +84,13 @@ static rpmRC audit_tsm_post(rpmPlugin plugin, rpmts ts, int res)
rasprintf(&eventTxt,
"op=%s %s sw_type=rpm key_enforce=%u gpg_res=%u %s",
op, nevra, enforce, verified, dir);
- audit_log_user_comm_message(auditFd, AUDIT_SOFTWARE_UPDATE,
- eventTxt, NULL, NULL, NULL, NULL, result);
+ if (audit_log_user_comm_message(auditFd, AUDIT_SOFTWARE_UPDATE,
Yup. This is the kind of stuff that happens when you just want something quickly out of the way and instead of stopping to think for a second (because this is not the thing you're interested just now) you think to work around it somehow. And then later realize doing the right thing would've been at least as simple :facepalm: :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3445#discussion_r1842163108
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3445/review/2435989614 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241114/bbe9ecc0/attachment.html>
More information about the Rpm-maint
mailing list