[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

[Panu Matilainen]

Details in commit messages, but short summary: move the test-suite rpm configuration from --define's to a permanent file, and setup_env calls from the wrapper functions to RPMTEST_CHECK*(). As a result, run() becomes entirely redundant can be removed - that is, for a large class of tests, you can just use commands directly without any extra fubar.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3447

-- Commit Summary --

  * Drop leftover buildhost override from pinned tests
  * Add test to ensure buildhost inside test-suite is what we expect
  * Don't override root's .rpmmacros in tests
  * Start moving test-suite macro config from --defines to .rpmmacros
  * Move environment setup to RPMTEST_CHECK* directly
  * Drop apparently redundant rpmdb related defines from test run() wrapper
  * Eliminate the last --define from test-suite run() function
  * Eliminate all uses of the now redundant run() in test-suite
  * Eliminate a bunch of now unnecessary runroot() uses

-- File Changes --

    M tests/atlocal.in (19)
    A tests/data/macros.testenv (4)
    M tests/local.at (3)
    M tests/mktree.common (3)
    M tests/pinned/common/buildrepr.sh (1)
    M tests/rpmbuild.at (38)
    M tests/rpmdb.at (2)
    M tests/rpmi.at (2)
    M tests/rpmmacro.at (6)
    M tests/rpmquery.at (82)
    M tests/rpmspec.at (38)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3447.patch
https://github.com/rpm-software-management/rpm/pull/3447.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3447
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3447 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241115/9ba03fe4/attachment.html>