[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)
Michal Domonkos
notifications at github.com
Mon Nov 18 10:23:00 UTC 2024
@dmnks commented on this pull request.
> snapshot exec "$@" \
- --define "_buildhost testhost" \
- --define "_topdir /build"
+ --define "_tmppath /var/tmp"
This is indeed strange that `runroot` doesn't work with `/tmp` as `_tmppath`, I've looked at it closer but couldn't find the culprit, it's probably related to some `tmpfs` foo, as you've noted in the commit message.
Nevertheless, we might as well just set `_tmppath` to `/var/tmp` in `macros.testenv` too which would eliminate the need for this override here.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3447#pullrequestreview-2442182183
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3447/review/2442182183 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241118/7278cafd/attachment.htm>
More information about the Rpm-maint
mailing list