[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

Michal Domonkos notifications at github.com
Mon Nov 18 10:57:13 UTC 2024


@dmnks commented on this pull request.



>      snapshot exec "$@" \
-             --define "_buildhost testhost" \
-             --define "_topdir /build"
+             --define "_tmppath /var/tmp"

That said, I've just realized we've been doing it previously the same way, `run` used to override `_tmppath` to `/tmp` for which there's also just one instance during the whole test-suite execution. So for tests that don't create a custom "snapshot" with `RPMTEST_SETUP`, we already were running them with a shared `/tmp` anyway.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3447#discussion_r1846378113
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3447/review/2442282499 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241118/78e6043a/attachment.htm>


More information about the Rpm-maint mailing list