[Rpm-maint] [rpm-software-management/rpm] Vacuum the sqlite rpmdb if necessary (PR #3452)

Panu Matilainen notifications at github.com
Tue Nov 19 08:19:11 UTC 2024


@pmatilai commented on this pull request.



>  		sqlexec(sdb, "PRAGMA optimize");
 		sqlexec(sdb, "PRAGMA wal_checkpoint = TRUNCATE");
+
+		int max_size = rpmExpandNumeric("%{?_sqlite_vacuum}");
+		if (max_size <= 0)
+		    max_size = 20*1024*1024;

I initially misread this, which is why I didn't comment earlier: %_sqlite_vacuum should not be in *bytes*, that makes no sense at all. The kind of ballpark range we care about is megabytes, but if for testing purposes it needs to be kilos then so be it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3452#pullrequestreview-2444682379
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3452/review/2444682379 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241119/2326845e/attachment.htm>


More information about the Rpm-maint mailing list