[Rpm-maint] [rpm-software-management/rpm] Make macros::expand_numeric return int64_t (PR #3454)

Panu Matilainen notifications at github.com
Tue Nov 19 13:45:21 UTC 2024


@pmatilai commented on this pull request.



>      if (arg == NULL)
 	return 0;
     auto [ ign, val ] = macros().expand_numeric(arg);
-    return val;
+    res = std::clamp(val, (int64_t) INT_MIN, (int64_t) INT_MAX);

Why the casts? It shouldn't need them, AFAICS.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3454#pullrequestreview-2445523850
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3454/review/2445523850 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241119/db90f504/attachment.htm>


More information about the Rpm-maint mailing list