[Rpm-maint] [rpm-software-management/rpm] Make macros::expand_numeric return int64_t (PR #3454)

Panu Matilainen notifications at github.com
Tue Nov 19 14:34:08 UTC 2024


@pmatilai commented on this pull request.



> @@ -1992,10 +1994,15 @@ rpmExpand(const char *arg, ...)
 int
 rpmExpandNumeric(const char *arg)
 {
+    int res;

Guess I just didn't notice this before, but don't introduce uninitialized variables. Nothing needs `res` until it gets the value from the clamp, so just introduce it there.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3454#pullrequestreview-2445660970
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3454/review/2445660970 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241119/dd2ea5e5/attachment-0001.htm>


More information about the Rpm-maint mailing list