[Rpm-maint] [rpm-software-management/rpm] Make macros::expand_numeric return int64_t (PR #3454)

Panu Matilainen notifications at github.com
Tue Nov 19 14:38:22 UTC 2024


@pmatilai commented on this pull request.



> @@ -9,6 +9,8 @@
 #include <string>
 #include <vector>
 #include <stack>
+#include <cinttypes>
+#include <algorithm>

I've been mostly trying to keep the C++ includes to alphabetic order. The pre-existing includes in this file are obviously failing to do so, but lets try to stick to that whenever there's no reason to deviate from it. Mind, that's not documented anywhere, we need to really start collecting the new rules somewhere....

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3454#pullrequestreview-2445675477
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3454/review/2445675477 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241119/0e6466d3/attachment.htm>


More information about the Rpm-maint mailing list