[Rpm-maint] [rpm-software-management/rpm] Fix regression on build-id generation from compressed ELF files (PR #3463)

Panu Matilainen notifications at github.com
Fri Nov 22 07:58:48 UTC 2024


Another cmake fallout - we even have the define in config.h.in but the actual test was missing, causing us to never use the compression aware dwelf_elf_begin() version.

The only reproducer I'm aware of is a kernel module, and we don't want to pull in the huge kernel-devel to the test CI for this. Manually verified that cmake looks for and finds it:

	-- Looking for dwelf_elf_begin in dw
	-- Looking for dwelf_elf_begin in dw - found

And building kernel module, before:

$ rpm -qpl /home/pmatilai/rpmbuild/RPMS/x86_64/kmod-lkm_example-1.0-1.x86_64.rpm /lib/modules/6.11.8-300.fc41.x86_64/lkm_example/lkm_example.ko.xz

After:

$ rpm -qpl /home/pmatilai/rpmbuild/RPMS/x86_64/kmod-lkm_example-1.0-1.x86_64.rpm /lib/modules/6.11.8-300.fc41.x86_64/lkm_example/lkm_example.ko.xz /usr/lib/.build-id
/usr/lib/.build-id/db
/usr/lib/.build-id/db/f83477ef46b0e51abd5cc1b9382be1330083c4

Fixes: RHEL-54000
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3463

-- Commit Summary --

  * Fix regression on build-id generation from compressed ELF files

-- File Changes --

    M CMakeLists.txt (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3463.patch
https://github.com/rpm-software-management/rpm/pull/3463.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3463
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3463 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241121/f1c81f2d/attachment.htm>


More information about the Rpm-maint mailing list