[Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3474)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +    auto macros = rpm::macros();
+    auto [mrc, keyringpath] = macros.expand("%{_keyringpath}");
+    while ('/' == keyringpath.back())
+	keyringpath.pop_back();
+    std::string path = rpm::expand_path({rpmtxnRootDir(txn), keyringpath});
+    std::string tmppath = keyringpath + ".tmp/";
+    std::string oldpath = keyringpath + ".rpmold/";
+    std::error_code ec = {};
+    rpmRC rc = RPMRC_OK;
+
+    macros.push("_keyringpath", "", tmppath.c_str(), 0);
+
+    rpmPubkey key = NULL;
+    auto iter = rpmKeyringInitIterator(keys, 0);
+    while ((rc == RPMRC_OK) && (key = rpmKeyringIteratorNext(iter))) {
+	rc = store->import_key(txn, key, 0, 0);

This will stop on first error, which seems contrary to the goal of weeding out bad keys with warning.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3474#pullrequestreview-2468261095
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3474/review/2468261095 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241128/c0480182/attachment-0001.htm>