[Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3474)

Panu Matilainen notifications at github.com
Thu Nov 28 14:03:20 UTC 2024


@pmatilai commented on this pull request.



> +    /* XXX keyring wont load if sigcheck disabled, force it temporarily */
+    rpmtsSetVSFlags(ts, (oflags & ~RPMVSF_MASK_NOSIGNATURES));
+
+    rpmKeyring keyring = rpmKeyringNew();
+
+    keystore_fs ks_fs = {};
+    rpmKeyring keyring_fs = rpmKeyringNew();
+    ks_fs.load_keys(txn, keyring);
+
+    keystore_rpmdb ks_rpmdb = {};
+    rpmKeyring keyring_rpmdb = rpmKeyringNew();
+    ks_rpmdb.load_keys(txn, keyring_rpmdb);
+
+    keystore_openpgp_cert_d ks_opengpg = {};
+    rpmKeyring keyring_openpgp = rpmKeyringNew();
+    ks_opengpg.load_keys(txn, keyring_openpgp);

Um. Why should we load up all possible keystore types?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3474#pullrequestreview-2468263515
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3474/review/2468263515 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241128/dfaa12a6/attachment.htm>


More information about the Rpm-maint mailing list