[Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3474)

[Panu Matilainen]

The above isn't a "full review", just remarks on stuff that immediately caught my eye.

An observation, not on this PR but this keystore thing in general: like we discussed, the keystore not having any internal state seemed weird and wrong. In retrospective it indeed is. The keystore should take the keyring path as an optional argument and remember it, macro values changing after initialization "obviously" must not affect an existing keystore. I remember thinking about that but then somehow conflating it with the txn root directory. And this PR pays the price for that mistake - seems obvious now but... oh well. 

Another, sort of related observation is that if temporary macros like the %_keyringpath here are a common use-case, we could arrange the cleanup to occur automatically with the macro context handle destructor.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3474#issuecomment-2506253638
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3474/c2506253638 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241128/5472aafb/attachment.htm>