[Rpm-maint] [rpm-software-management/rpm] Stringify the rest of the internal c++ macro API (PR #3477)

Vít Ondruch notifications at github.com
Fri Nov 29 09:43:46 UTC 2024


@voxik commented on this pull request.



> @@ -1774,13 +1781,14 @@ static void pushMacroAny(rpmMacroContext mc,
 }
 
 static void pushMacro(rpmMacroContext mc,
-	const char * n, const char * o, const char * b, int level, int flags)
+		const string & n, const char * o, const string & b,

I might be missing something, but using `string` on some places while `std::string` on other places seems inconsistent to me.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3477#pullrequestreview-2469507022
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3477/review/2469507022 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241129/67b15f23/attachment-0001.htm>


More information about the Rpm-maint mailing list