[Rpm-maint] [rpm-software-management/rpm] Stringify the rest of the internal c++ macro API (PR #3477)
Panu Matilainen
notifications at github.com
Fri Nov 29 10:20:53 UTC 2024
@pmatilai commented on this pull request.
> @@ -1774,13 +1781,14 @@ static void pushMacroAny(rpmMacroContext mc,
}
static void pushMacro(rpmMacroContext mc,
- const char * n, const char * o, const char * b, int level, int flags)
+ const string & n, const char * o, const string & b,
Yup. Typing the namespace everywhere seems tedious, but the alternative starts quickly looking worse.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3477#discussion_r1863295894
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3477/review/2469583560 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241129/d38de575/attachment.htm>
More information about the Rpm-maint
mailing list