[Rpm-maint] [rpm-software-management/rpm] Only configure git user if needed (PR #3472)

[Jan Staněk]

> _This_ is easy to agree with. And easist dealt with by adding --no-signoff to our git commit commands, it's the right thing to do really.

Unfortunately won't help me. ;-) It's not signing-off the patches when it makes them (`am`/`commit`), it's signing them off when I export them (`format-patch`) – and that is something outside of your control. Either I have to remember to add `--no-signoff` to my commands, or disable it globally.

Alternatively, if we want to stay with the rpm-build user in *all* cases, adding a line of `git config format.signOff false` to the init macro would also solve it, overwriting my global setup on the repo level. However, this could lead to a "whack-a-mole" situation when we will try to undo any possible global git option that would interact with the repo config in unexpected way. I was trying to move in the direction of least astonishment, keeping the repo-level configuration as close to any other git repo the user could have on their machine.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3472#issuecomment-2507618014
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3472/c2507618014 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241129/db857909/attachment.htm>