[Rpm-maint] [rpm-software-management/rpm] Only configure git user if needed (PR #3472)

[Panu Matilainen]

Oh, I didn't know format-patches would apply signoffs too. Seems kinda strange, but then in an email-based workflow...

In any case, this already is a case of whack-a-mole, the git usage inside rpmbuild is nothing like any normal repo usage is, so we keep running into these wrinkles every now and then. This sure isn't the first, nor the last. 

But you said you're using git_am. In which case rpm really shouldn't override the author at all. So *that* seems like the real bug here. The non-am version was added first and there the user/email simply isn't expected to exist and rpm has to put *something* there, whereas with git am the user info *has* to be there already. So I think the right thing to do, really, is to separate the setup of these two different forms. Right now, git_am setup simply calls git setup.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3472#issuecomment-2507844156
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3472/c2507844156 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241129/d8b41a3d/attachment.htm>