[Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -107,6 +117,22 @@ rpmPubkey rpmPubkeyLink(rpmPubkey key);
  */
 char * rpmPubkeyBase64(rpmPubkey key);
 
+/** \ingroup rpmkeyring
+ * Return fingerprint of primary key
+ * @param key		Pubkey
+ * @param fp		Fingerprint data
+ * @param fplen		Length of Fingerprint
+ * @return		0 on success
+ */
+int rpmPubkeyFingerprint(rpmPubkey key, uint8_t **fp, size_t *fplen);

Something that occurred to me just yesterday evening: do we actually need the binary version of the key fingerprint for anything? Dealing with a binary buffer is annoying in C, and doubly so if/when the caller only ever wants to print it in hex, which I think is the primary usecase for this.

So even if we want to retain the binary version, we should offer one that returns the hex string so that each and every caller doesn't need to juggle with that by themselves.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3321#pullrequestreview-2339118863
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3321/review/2339118863 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20240930/0b045293/attachment.html>