[Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

Panu Matilainen notifications at github.com
Tue Oct 1 10:46:30 UTC 2024


@pmatilai commented on this pull request.



> @@ -590,9 +615,11 @@ static rpmRC
 verifySignature(rpmKeyring keyring, struct rpmsinfo_s *sinfo)
 {
     rpmRC res = RPMRC_FAIL;
-    if (pgpSignatureType(sinfo->sig) == PGPSIGTYPE_BINARY)
-	res = rpmKeyringVerifySig(keyring, sinfo->sig, sinfo->ctx);
-
+    if (pgpSignatureType(sinfo->sig) == PGPSIGTYPE_BINARY) {
+	rpmPubkey key = NULL;
+	res = rpmKeyringVerifySig2(keyring, sinfo->sig, sinfo->ctx, &key);

It's not about saving lines but making it more obvious really. Unnecessary stuff just obfuscates things.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3321#discussion_r1782548327
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3321/review/2339836186 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241001/e98fdbac/attachment.html>


More information about the Rpm-maint mailing list