[Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

Panu Matilainen notifications at github.com
Wed Oct 2 05:58:04 UTC 2024


@pmatilai commented on this pull request.



> @@ -288,7 +346,15 @@ rpmRC rpmKeyringVerifySig(rpmKeyring keyring, pgpDigParams sig, DIGEST_CTX ctx)
 	    rpmlog(rc ? RPMLOG_ERR : RPMLOG_WARNING, "%s\n", lints);
 	    free(lints);
 	}
+	if (keyptr) {
+	    *keyptr = rpmPubkeyLink(key);

Yesterday's talk about the backwards way subkeys are added made me realize another thing:
Since all we care about is the fingerprint of the primary key, why are we sending it subkeys to begin with?
This all should be a lot, lot easier if we just toss in the primary key from here, don't even need the public rpmPubkeyPrimaryKey() API then.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3321#pullrequestreview-2341945110
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3321/review/2341945110 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241001/e1b7d73b/attachment-0001.html>


More information about the Rpm-maint mailing list