[Rpm-maint] [rpm-software-management/rpm] Add Key Fingerprints to rpmsinfoMsg() (PR #3321)

Panu Matilainen notifications at github.com
Thu Oct 3 05:52:59 UTC 2024


@pmatilai commented on this pull request.



>  {
     rpmPubkey key = new rpmPubkey_s {};
-    /* Packets with all subkeys already stored in main key */
+    /* Packets with all subkeys already stored in primary key */
+    key->primarykey = primarykey;

I suppose it should actually take the reference here already, might simplify the rest of stuff as well.
But l agree, lets take another look at the whole in #3350/#3351, it should be easier to see the big picture when this is already in place. We're both getting battle-weary on this PR.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3321#pullrequestreview-2344701054
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3321/review/2344701054 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241002/6c10bc53/attachment-0001.html>


More information about the Rpm-maint mailing list