[Rpm-maint] [rpm-software-management/rpm] Mass rename C++ sources to .cc/.hh extension (PR #3356)
Panu Matilainen
notifications at github.com
Thu Oct 3 10:16:53 UTC 2024
As planned from the start of the C++ journey, rename all C++ files to a C++ extension to remove the confusion for both humans and tooling - so we now get to remove the associated cmake hacks to force it to use a C++ compiler.
We initially decided on going for .cxx/.hxx extension on the grounds that it's the technically most right thing to do as it matches with the build toolchain CXX/CXXFLAGS and all that. But at around 1/4 way through the rename I concluded that this is not only eye-bleeding ugly, it also totally obfuscates the difference between headers and sources in the visual noise it creates. Last but not least, it makes you think of All My Ex's Live in Texas, and that's about the last thing in I want to be thinking off. Both the song, and the exes.
Those of us working on rpm for a living need to think of their well-being, both mental and physical. The choice of .cc/.hh extension is primarily based on that: the .cxx/.hxx extension proved to be almost revolting in practise. To my total surprise really, I never expected this to matter at all. Maybe others have had similar feelings though, .cc/.hh is one of the more common choices, for example gcc and binutils use that.
Fixes: #3316
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3356
-- Commit Summary --
* Fix up rpmuncompress not being compiled as C++
* Mass rename C++ sources to .cc/.hh extension
-- File Changes --
M build/CMakeLists.txt (23)
R build/build.cc (4)
R build/files.cc (8)
R build/misc.cc (2)
R build/pack.cc (11)
R build/parseChangelog.cc (2)
R build/parseDescription.cc (2)
R build/parseFiles.cc (2)
R build/parseList.cc (2)
R build/parsePolicies.cc (2)
R build/parsePreamble.cc (4)
R build/parsePrep.cc (6)
R build/parseReqs.cc (4)
R build/parseScript.cc (10)
R build/parseSimpleScript.cc (2)
R build/parseSpec.cc (4)
R build/policies.cc (4)
R build/reqprov.cc (2)
R build/rpmbuild_internal.hh (4)
R build/rpmbuild_misc.hh (0)
R build/rpmfc.cc (4)
R build/spec.cc (4)
R build/speclua.cc (4)
M lib/CMakeLists.txt (62)
R lib/backend/bdb_ro.cc (2)
R lib/backend/dbi.cc (2)
R lib/backend/dbi.hh (2)
R lib/backend/dbiset.cc (2)
R lib/backend/dbiset.hh (0)
R lib/backend/dummydb.cc (2)
R lib/backend/ndb/glue.cc (2)
R lib/backend/sqlite.cc (2)
R lib/cpio.cc (2)
R lib/cpio.hh (0)
R lib/depends.cc (12)
R lib/formats.cc (8)
R lib/fprint.cc (10)
R lib/fprint.hh (0)
R lib/fsm.cc (12)
R lib/fsm.hh (0)
R lib/header.cc (4)
R lib/header_internal.hh (2)
R lib/headerfmt.cc (2)
R lib/headerutil.cc (0)
R lib/manifest.cc (2)
R lib/manifest.hh (0)
R lib/misc.hh (2)
R lib/order.cc (4)
R lib/package.cc (8)
R lib/poptALL.cc (0)
R lib/poptI.cc (0)
R lib/poptQV.cc (2)
R lib/psm.cc (24)
R lib/query.cc (4)
R lib/relocation.cc (4)
R lib/rpmal.cc (12)
R lib/rpmal.hh (0)
R lib/rpmchecksig.cc (8)
R lib/rpmchroot.cc (4)
R lib/rpmchroot.hh (0)
R lib/rpmdb.cc (14)
R lib/rpmdb_internal.hh (2)
R lib/rpmds.cc (2)
R lib/rpmds_internal.hh (0)
R lib/rpmfi.cc (12)
R lib/rpmfi_internal.hh (2)
R lib/rpmfs.cc (2)
R lib/rpmfs.hh (0)
R lib/rpmgi.cc (4)
R lib/rpmgi.hh (0)
R lib/rpminstall.cc (4)
R lib/rpmlead.cc (6)
R lib/rpmlead.hh (0)
R lib/rpmlock.cc (2)
R lib/rpmlock.hh (0)
R lib/rpmplugins.cc (2)
R lib/rpmplugins.hh (0)
R lib/rpmprob.cc (0)
R lib/rpmps.cc (0)
R lib/rpmrc.cc (10)
R lib/rpmscript.cc (10)
R lib/rpmscript.hh (0)
R lib/rpmtd.cc (2)
R lib/rpmte.cc (12)
R lib/rpmte_internal.hh (2)
R lib/rpmtriggers.cc (14)
R lib/rpmtriggers.hh (2)
R lib/rpmts.cc (16)
R lib/rpmts_internal.hh (12)
R lib/rpmug.cc (4)
R lib/rpmug.hh (0)
R lib/rpmvs.cc (4)
R lib/rpmvs.hh (2)
R lib/signature.cc (6)
R lib/signature.hh (0)
R lib/tagexts.cc (2)
R lib/tagname.cc (0)
R lib/transaction.cc (25)
R lib/verify.cc (8)
M plugins/fsverity.c (2)
M rpmio/CMakeLists.txt (28)
R rpmio/argv.cc (0)
R rpmio/base64.cc (0)
R rpmio/digest.cc (0)
R rpmio/digest_libgcrypt.cc (0)
R rpmio/digest_openssl.cc (0)
R rpmio/expression.cc (6)
R rpmio/lposix.cc (8)
R rpmio/lposix.hh (0)
R rpmio/macro.cc (4)
R rpmio/modemuncher.cc (0)
R rpmio/rgetopt.cc (2)
R rpmio/rpmfileutil.cc (2)
R rpmio/rpmglob.cc (0)
R rpmio/rpmhook.cc (2)
R rpmio/rpmhook.hh (0)
R rpmio/rpmio.cc (2)
R rpmio/rpmio_internal.hh (0)
R rpmio/rpmkeyring.cc (0)
R rpmio/rpmlog.cc (0)
R rpmio/rpmlua.cc (10)
R rpmio/rpmlua.hh (0)
R rpmio/rpmmacro_internal.hh (0)
R rpmio/rpmmalloc.cc (0)
R rpmio/rpmpgp.cc (4)
R rpmio/rpmpgp_dummy.cc (2)
R rpmio/rpmpgp_sequoia.cc (2)
R rpmio/rpmpgpval.hh (0)
R rpmio/rpmsq.cc (0)
R rpmio/rpmstring.cc (0)
R rpmio/rpmstrpool.cc (0)
R rpmio/rpmsw.cc (0)
R rpmio/rpmver.cc (0)
R rpmio/rpmvercmp.cc (0)
R rpmio/url.cc (0)
M sign/CMakeLists.txt (11)
R sign/rpmgensig.cc (12)
R sign/rpmsignfiles.cc (2)
R sign/rpmsignfiles.hh (0)
R sign/rpmsignverity.cc (8)
R sign/rpmsignverity.hh (0)
M tools/CMakeLists.txt (37)
R tools/cliutils.cc (2)
R tools/cliutils.hh (0)
R tools/elfdeps.cc (0)
R tools/rpm.cc (2)
R tools/rpm2archive.cc (0)
R tools/rpmbuild.cc (2)
R tools/rpmdb.cc (2)
R tools/rpmdeps.cc (0)
R tools/rpmdump.cc (0)
R tools/rpmgraph.cc (2)
R tools/rpmkeys.cc (2)
R tools/rpmlua.cc (4)
R tools/rpmsign.cc (2)
R tools/rpmsort.cc (0)
R tools/rpmspec.cc (2)
R tools/rpmuncompress.cc (6)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/3356.patch
https://github.com/rpm-software-management/rpm/pull/3356.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3356
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3356 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241003/e147b380/attachment-0001.html>
More information about the Rpm-maint
mailing list