[Rpm-maint] [rpm-software-management/rpm] Lock key during rpmGetSubkeys() (PR #3364)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -179,7 +179,12 @@ rpmPubkey *rpmGetSubkeys(rpmPubkey primarykey, int *count)
     int pgpsubkeysCount = 0;
     int i;
 
-    if (primarykey && !pgpPrtParamsSubkeys(primarykey->pkt.data(), primarykey->pkt.size(),
+    if (!primarykey)
+	return NULL;

*count was previously unconditionally set (ie even if key was NULL), so that behavior should be kept, somebody might be relying on it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3364#pullrequestreview-2356258613
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3364/review/2356258613 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241009/5e1eab8e/attachment.html>