[Rpm-maint] [rpm-software-management/rpm] Pass rpmPubkey instance to rpmtxnDeletePubkey (PR #3374)

Panu Matilainen notifications at github.com
Mon Oct 14 12:08:08 UTC 2024


@pmatilai commented on this pull request.



> @@ -359,7 +360,7 @@ rpmRC rpmtxnImportPubkey(rpmtxn txn, const unsigned char * pkt, size_t pktlen);
  * 			RPMRC_NOKEY on invalid keyid
  * 			RPMRC_FAIL on other failure
  */
-rpmRC rpmtxnDeletePubkey(rpmtxn txn, const char *keyid);
+rpmRC rpmtxnDeletePubkey(rpmtxn txn, rpmPubkey key);

I'm okay with adding an alternative API for this that takes a pubkey, and I'm okay with using this name for it even, but don't *remove* the version that takes a fingerprint. I explained why in the PR that added it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3374#pullrequestreview-2366419390
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3374/review/2366419390 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241014/d87cd7aa/attachment.html>


More information about the Rpm-maint mailing list