[Rpm-maint] [rpm-software-management/rpm] Fix FA_TOUCH'ed files getting removed on failed update (PR #3393)

[Panu Matilainen]

On install/update, most files are laid down with a temporary suffix and if the update fails, removing those at the end of the loop is the right thing to do. However FA_TOUCH'ed files were already there, we only update their metadata, and we better not remove them!

AFAICS this all versions since rpm >= 4.14 in one way or the other. If %_minimize_writes is enabled then it affects way more than just unmodified config files.

The test is a simplified version of pam update failing in the original report.

Fixes: RHEL-54386
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3393

-- Commit Summary --

  * Fix FA_TOUCH'ed files getting removed on failed update

-- File Changes --

    M lib/fsm.cc (2)
    A tests/data/SPECS/pamupdate.spec (21)
    M tests/rpmi.at (39)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3393.patch
https://github.com/rpm-software-management/rpm/pull/3393.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3393
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3393 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241021/6b7d9960/attachment.html>