[Rpm-maint] [rpm-software-management/rpm] rpmKeyring: Support keys with the same key ID (PR #3398)

Panu Matilainen notifications at github.com
Thu Oct 24 06:29:43 UTC 2024


@pmatilai commented on this pull request.



>  	    free(lints);
 	}
-	if (keyptr) {
-	    *keyptr = pubkeyPrimarykey(key);
+
+	for (auto const & item : results) {
+	    if (((rc == RPMRC_OK) == (item.first == RPMRC_OK))
+		&& item.second != "")

item.second.empty() would be the more appropriate test for an empty C++ string. Not that it affects the results here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3398#pullrequestreview-2391420237
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3398/review/2391420237 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241023/c419893d/attachment-0001.html>


More information about the Rpm-maint mailing list