[Rpm-maint] [rpm-software-management/rpm] rpmKeyring: Support keys with the same key ID (PR #3398)

Panu Matilainen notifications at github.com
Thu Oct 24 06:45:12 UTC 2024


@pmatilai commented on this pull request.



>      rpmPubkey key = NULL;
+    std::vector<std::pair<int, std::string>> results = {};

And here too - the results vector is only needed inside the main if, so that's where it belongs. And key inside the only code that can actually end with it being set.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3398#pullrequestreview-2391460713
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3398/review/2391460713 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20241023/06a9c36d/attachment.html>


More information about the Rpm-maint mailing list