[Rpm-maint] [rpm-software-management/rpm] Print binaries of non-matching arch in the warning/error message (PR #4060)

[Michal Domonkos]

@dmnks commented on this pull request.



> +
+    /* Gather outlier binaries to print */
+    for (ix = 0; ix < fc->nfiles; ix++) {
+	color = fc->fcolor[ix];
+	if (!color || color == arch_color)
+	    continue;
+	type = rpmfcPrettyFType(fc, ix);
+	bins += string(4, ' ') + fc->fn[ix].substr(fc->buildRoot.size());
+	if (!type.empty())
+	    bins += " (" + type + ")";
+	bins += '\n';
+    }
+
+    nvr = headerGetAsString(pkg->header, RPMTAG_NVRA);
+    rpmlog(terminate ? RPMLOG_ERR : RPMLOG_WARNING,
+	   _(msg.c_str()), nvr, bins.c_str());

Oops, thanks for spotting!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4060#discussion_r2592707960
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4060/review/3544786562 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20251205/b9bdaa20/attachment.htm>