[Rpm-maint] [rpm-software-management/rpm] Print binaries of non-matching arch in the warning/error message (PR #4060)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +	color = fc->fcolor[ix];
+	if (!color || color == arch_color)
+	    continue;
+	type = rpmfcPrettyFType(fc, ix);
+	bins += string(4, ' ') + fc->fn[ix].substr(fc->buildRoot.size());
+	if (!type.empty())
+	    bins += " (" + type + ")";
+	bins += '\n';
+    }
+
+    nvr = headerGetAsString(pkg->header, RPMTAG_NVRA);
+    rpmlog(terminate ? RPMLOG_ERR : RPMLOG_WARNING,
+	   _(msg.c_str()), nvr, bins.c_str());
+    free(nvr);
+
+    return (terminate ? RPMRC_FAIL : RPMRC_OK);

This is actually one of those rare cases where the extra parentheses don't help readability.
They help around the individual components (if non-trivial) but here, it makes you look for some trick that doesn't actually exist :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4060#pullrequestreview-3544790371
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4060/review/3544790371 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20251205/5ab6ffee/attachment.htm>