[Rpm-maint] [rpm-software-management/rpm] Print binaries of non-matching arch in the warning/error message (PR #4060)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -1640,6 +1640,60 @@ rpmRC rpmfcApply(rpmfc fc)
     return rc;
 }
 
+static string rpmfcPrettyFType(rpmfc fc, unsigned ix)
+{
+    string ftype = fc->ftype[ix];
+    size_t len = ftype.find(' ', 10);
+    return ftype.substr(0, len);
+}
+
+static rpmRC rpmfcCheckPackageColor(rpmfc fc)
+{
+    Package pkg = fc->pkg;
+    const char *a = headerGetString(pkg->header, RPMTAG_ARCH);
+    char *nvr;
+    string msg, type, bins;
+    unsigned ix;
+    int color;

Oh yup, rpm has tons of bad examples here, old school coding style where all variables are declared at the top. It's nothing but asking for trouble - stuff like reusing an int in multiple for-loops and sometimes in between, and then you try to figure if there's interplay or not :zany_face: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4060#discussion_r2592725606
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4060/review/3544806957 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20251205/8328d0bc/attachment.htm>