[Rpm-maint] [rpm-software-management/rpm] Check not configured keystore backends for keys (PR #3539)

[Florian Festi]

@ffesti commented on this pull request.



> @@ -71,6 +71,19 @@ rpmKeyring rpmKeyringFree(rpmKeyring keyring)
     return NULL;
 }
 
+size_t rpmKeyringSize(rpmKeyring keyring, int count_subkeys)
+{
+    if (!keyring) return 0;
+    rdlock lock(keyring->mutex);
+
+    size_t size = 0;
+    for (auto &pair : keyring->keys) {
+	if (count_subkeys or !pair.second->primarykey)

Turns out `and` and `or` are totally legal operators in C++. They are different to both the `&` and `&&` variants in that they are boolean and not binary but they are not short circuit but true operators that keep things as a true expression.

Still general consensus seems to be to not use them unless your audience is hard core Python programmers...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3539#discussion_r1940799148
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3539/review/2592213855 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250204/691e202b/attachment.htm>