[Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -406,6 +406,50 @@ rpmRC rpmtsImportPubkey(const rpmts ts, const unsigned char * pkt, size_t pktlen
     return rc;
 }
 
+rpmRC rpmtsRebuildKeystore(rpmtxn txn, const char * from)
+{
+    rpmts ts = rpmtxnTs(txn);
+    rpmRC rc = RPMRC_OK;
+    rpmKeyring keyring = rpmtsGetKeyring(ts, 1);
+    keystore_fs ks_fs = {};
+    keystore_rpmdb ks_rpmdb = {};
+    keystore_openpgp_cert_d ks_opengpg = {};
+    rpmKeyringIterator iter = NULL;
+
+    if (rpmtsOpenDB(txn->ts, (O_RDWR|O_CREAT))) {

This looks just wrong. If we're rebuilding an fs or openpgp keyring, the rpmdb doesn't come into play at all.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#pullrequestreview-2616944019
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3562/review/2616944019 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250213/07a78b21/attachment.htm>