[Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +	for (keystore *ks : std::vector<keystore*>
+		 {&ks_fs, &ks_rpmdb, &ks_opengpg}) {
+	    if (ks->name == from and ks->name != ts->keystore->name) {
+		ks->load_keys(txn, keyring);
+		found = true;
+	    }
+	}
+	if (not found) {
+	    rpmlog(RPMLOG_ERR, _("No key store backend %s"), from);
+	    rc = RPMRC_FAIL;
+	    goto exit;
+	}
+    }
+    for (keystore *ks : std::vector<keystore*>
+	     {&ks_fs, &ks_rpmdb, &ks_opengpg}) {
+	ks->delete_store(txn);

We shouldn't be deleting anything we were not asked to. Only the source.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#pullrequestreview-2616945785
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3562/review/2616945785 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250213/81aa7f85/attachment.htm>