[Rpm-maint] [rpm-software-management/rpm] Implement rpmkeys --rebuild (PR #3562)

[Panu Matilainen]

@pmatilai commented on this pull request.



>  
     virtual ~keystore() = default;
+    keystore(std::string n): name(n) {};

Something was nagging me about this name thing all along, and now I know what it was:  
We're now duplicating info with getKeystore() here. Instead, the name should be a static property, and then we should have an std::array of available types. And then getKeystore() can use that array to look up the right thing from the classes themselves. Like the rpmdb backend does. And, when you have a function that returns a backend based on a name, both getKeystore() and the --from logic can use that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3562#pullrequestreview-2617015489
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3562/review/2617015489 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250214/e98c43f7/attachment-0001.htm>