[Rpm-maint] [rpm-software-management/rpm] Fix regression on buildarchtranslate overrides (PR #3583)

Panu Matilainen notifications at github.com
Wed Feb 19 13:00:26 UTC 2025


Commit 7be4b79581a451f750242485ec1923ca96df9e5b didn't account for the fact that there can be multiple source values for the same key, and that order matters: to honor the default < vendor < host < user override system, we need to use the last, not the first value we encounter. And .insert() on an STL map only inserts if the they doesn't already exist. Oops. Add a test as well.

Fixes: #3582
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3583

-- Commit Summary --

  * Fix regression on buildarchtranslate overrides

-- File Changes --

    M lib/rpmrc.cc (2)
    M tests/rpmgeneral.at (13)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3583.patch
https://github.com/rpm-software-management/rpm/pull/3583.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3583
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3583 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250219/dd4f7ab8/attachment.htm>


More information about the Rpm-maint mailing list