[Rpm-maint] [rpm-software-management/rpm] Extend dbus-announce plugin (PR #3532)
Michal Domonkos
notifications at github.com
Mon Feb 24 11:34:19 UTC 2025
@dmnks commented on this pull request.
> @@ -103,9 +119,77 @@ static rpmRC send_ts_message(rpmPlugin plugin,
dbcookie = rpmdbCookie(rpmtsGetRdb(ts));
rpm_tid_t tid = rpmtsGetTid(ts);
+
+ if (!dbus_message_append_args(msg,
+ DBUS_TYPE_STRING, &dbcookie,
+ DBUS_TYPE_UINT32, &tid,
+ DBUS_TYPE_INVALID))
+ goto err;
+
+ if (!dbus_connection_send(state->bus, msg, NULL))
+ goto err;
+
+ if (snprintf(detail_name, sizeof(detail_name), "%sDetails", name) >= sizeof(detail_name)) {
Thanks for checking (the limits). It indeed looks like we don't have to worry about the message size too much then :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3532#discussion_r1967472263
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3532/review/2636792789 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250224/f1ac432a/attachment.htm>
More information about the Rpm-maint
mailing list