[Rpm-maint] [rpm-software-management/rpm] Extend dbus-announce plugin (PR #3532)

[Michal Domonkos]

@dmnks commented on this pull request.



> +	       (unsigned int)(strlen(name) + strlen("Details") + 1));
+        goto err;
+    }
+
+    dbus_message_unref(msg);
+
+    /* it's used in the log below, thus to have proper signal name in there */
+    name = detail_name;
+    msg = dbus_message_new_signal("/org/rpm/Transaction", /* object name */
+				  "org.rpm.Transaction",  /* interface name */
+				  name);                  /* signal name */
+    if (msg == NULL)
+	goto err;
+
+    nElems = rpmtsNElements(ts);
+    array = (char **) malloc((nElems + 1 ) * sizeof(char *));

Already mentioned in another thread but please use `ARGV_t` here (and the accompanying functions such as `argvAdd()` and `argvFree()`).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3532#pullrequestreview-2636804452
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3532/review/2636804452 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250224/85a62877/attachment.htm>