[Rpm-maint] [rpm-software-management/rpm] Extend dbus-announce plugin (PR #3532)

Michal Domonkos notifications at github.com
Mon Feb 24 11:49:32 UTC 2025


dmnks left a comment (rpm-software-management/rpm#3532)

Apologies for leaving this PR rot for two weeks :sweat_smile: Anyway, coming back to it with a fresh perspective helped, see my comments above.

I'm also thinking, wouldn't it be cleaner to just split `send_ts_message()` into two functions, one for the existing signals and one for the extended/detailed ones? That way, we wouldn't have to e.g. reuse the static `name` string and check its length.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3532#issuecomment-2678185043
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3532/c2678185043 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250224/5074b4fd/attachment.htm>


More information about the Rpm-maint mailing list