[Rpm-maint] [rpm-software-management/rpm] Convert main data structures in elfdeps to C++ (PR #3581)

Michal Domonkos notifications at github.com
Mon Feb 24 16:56:17 UTC 2025


@dmnks commented on this pull request.



>  
     if (filter_soname) {
-	if (!strstr(soname, ".so"))
-	    return 1;
-
-	if (rstreqn(soname, "ld.", 3) || rstreqn(soname, "ld-", 3) ||
-	    rstreqn(soname, "ld64.", 3) || rstreqn(soname, "ld64-", 3))

Heh, there seems to have been a bug here (comparing at most `3` chars whereas the tested strings are longer). That's now fixed with the conversion :smile: Nice.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3581#pullrequestreview-2637824891
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3581/review/2637824891 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20250224/6eec680b/attachment-0001.htm>


More information about the Rpm-maint mailing list